Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegration Fixes for Web Based Controllers #12
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jmkao commentedAug 8, 2016
Two small fixes:
window.location.href
instead of concatenating hostname and pathname so that the default URL path will work for https and when the server is listening on something other than port 80.The rest of the integration we are doing in a separate JS file that will call into the existing functions to pull calibration information and add functionality by modifying the DOM in code. You can see that in https://github.com/Kudo3D/SLAcer.js/blob/gh-pages/js/photonic3d.js
This can be a basis for #10.