/incubator-mxnet

[Perl] Bitrot fix. Viz and two flaky tests. #9414

Merged
merged 1 commit into from Jan 14, 2018
+25 −25

Conversation

Reviewers

@eric-haibin-lin eric-haibin-lin

@marcoabreu marcoabreu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergeykolychev @eric-haibin-lin @marcoabreu
@sergeykolychev
Contributor

sergeykolychev commented Jan 13, 2018 •
Edited 5 times

  1. fixed viz routines to be compatible with current symbol json.
  2. fixed two flaky tests.

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here
bitrot fix. 
1) fixed viz routines to be compatible with current symbol json.
2) fixed two flaky tests.
c0b70af
@sergeykolychev
Contributor

sergeykolychev commented Jan 13, 2018

#8928
perl-package/AI-MXNet/t/test_gluon_rnn.t
- mx->autograd->record(sub {
- $net->(mx->nd->ones([2, 3, 10]))->backward();
- });
+# my $net = gluon->nn->Sequential();
@eric-haibin-lin

eric-haibin-lin Jan 14, 2018

Contributor

Remove unused code?

@sergeykolychev

sergeykolychev Jan 14, 2018

Contributor

Just commented it for now so I'll remember to return to this later. There was one test failure in that part that was never reproduced after that and I'd like to get to the bottom of it later.
Currently I am working on adding sparse support to perl and don't have much time for this currently so I just commented the block.

@eric-haibin-lin

eric-haibin-lin Jan 14, 2018

Contributor

Just curious, anyone requested the sparse feature for perl?

@marcoabreu

marcoabreu Jan 14, 2018

Contributor

Maybe create an issue in order to keep track of it?

@sergeykolychev

sergeykolychev Jan 14, 2018

Contributor

@marcoabreu will do that, thanks.

@sergeykolychev sergeykolychev merged commit 171d717 into apache:master Jan 14, 2018
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@sergeykolychev
Contributor

sergeykolychev commented Jan 14, 2018 •
Edited 2 times

@sergeykolychev sergeykolychev referenced this pull request Jan 14, 2018

Open

Flaky Tests Tracking Issue #9412

CodingCat added a commit to CodingCat/mxnet that referenced this pull request Jan 16, 2018

@sergeykolychev @CodingCat
bitrot fix. (#9414) 
1) fixed viz routines to be compatible with current symbol json.
2) fixed two flaky tests.
5668a24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment