Skip to content

Challenge : Create an Ordered List - Improve tests #7576

Open
Fuzzylogics opened this Issue · 2 comments

2 participants

@Fuzzylogics

Challenge Create an Ordered List has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

My code:

<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">
<style>
  .red-text {
    color: red;
  }

  h2 {
    font-family: Lobster, Monospace;
  }

  p {
    font-size: 16px;
    font-family: Monospace;
  }

  .thick-green-border {
    border-color: green;
    border-width: 10px;
    border-style: solid;
    border-radius: 50%;
  }

  .smaller-image {
    width: 100px;
  }
</style>

<h2 class="red-text">CatPhotoApp</h2>

<p>Click here for <a href="#">cat photos</a>.</p>

<a href="#"><img class="smaller-image thick-green-border" alt="A cute orange cat lying on its back" src="https://bit.ly/fcc-relaxing-cat"></a>

<p>Things cats love:</p>
<ol>
  <li>cat nip</li>
  <li>laser pointers</li>
  <li>lasagna</li>
</ol>
<p>Top 3 things cats hate:</p>

<ul>
<li>Dogs</li>
<li>Water</li>
<li>Vacuum cleaner</li>  
</ul>


Edit

Issue Description:
The tests are checking for one set of ordered lists, and not specifically in which block. i.e.

<p>Top 3 things cats hate:</p>

Test to be improved.

@raisedadead
Free Code Camp member

@Fuzzylogics Okay your code is accidentally correct!

The first block of list is ORDERED.

<p>Things cats love:</p>
  <ol>
    <li>cat nip</li>
    <li>laser pointers</li>
    <li>lasagna</li>
  </ol>

The next block of list is UNORDERED

<p>Top 3 things cats hate:</p>
  <ul>
    <li>Dogs</li>
    <li>Water</li>
    <li>Vacuum cleaner</li>  
  </ul>

That's the probable reason this got you confused.

The tests could be improved to check specifically which block is ordered and which one is un-ordered as per the instruction:

Create an ordered list of the top 3 things cats hate the most.

@raisedadead raisedadead changed the title from Challenge "Create an Ordered List" says that I have to "Create an ordered list of the top 3 things cats hate the most." But tests run "OK" only if I create unordered list "<ul></ul>" instead of required ordered list "<ol></ol>". to Challenge : Create an Ordered List - Improve tests
@ghost

I do not own a Mac nor use these browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.