Skip to content

CORS error on Codepen for challenge [show-relationships-with-a-force-directed-graph] #7617

Open
skusku opened this Issue · 8 comments

5 participants

@skusku

Challenge Show Relationships with a Force Directed Graph has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Just opened the pen and it spits out a CORS error.

@ltegman
Free Code Camp member

I can confirm this. I assume it's due to the example using http instead of https.

@ltegman ltegman added the confirmed label
@kalunlee136

@Itergman Yeah, I tried changing the API request to https and it works fine.

@raisedadead
Free Code Camp member

@kalunlee136 It would be awesome if you could send in a PR!

@kalunlee136

@raisedadead i don't think i can fix the codepen problem, because the issue is that the example API request inside the pen uses HTTP (that's why if you open the pen the graph doesn't show up). I think we would need the owner of the pen to change it.

Though I can work on changing the Hint URL from the FCC challenge so people don't copy and paste the wrong URL.

@raisedadead
Free Code Camp member

@kalunlee136 The original Pen is by Free Code Camp (account under control of @QuincyLarson) so if you can create a Pen that has https within its code, then we could either clone it under the Free Code Camp account or use your pen.

Next thing though still would be to update the example links protocol to https in the challenge story as well!

@kalunlee136

@raisedadead ok, sounds good. I'll work on this.

@kalunlee136 kalunlee136 added a commit to kalunlee136/FreeCodeCamp that referenced this issue
@kalunlee136 kalunlee136 converted http to https for pen and other links. closes #7617. 8c1c4f3
@raisedadead
Free Code Camp member

Refer #7700 for similar issues.

@mutantspore

Yes, as the original author of
this D3 exercise, I have changed my original to https:// and can confirm that it works fine. I can't alter the official FCC version though. @QuincyLarson will have to do that.

Unfortunately with the phasing out of FCC News this is a dooooomed project anyway. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.