Skip to content

/FreeCodeCamp

Make Inventory Update function name unique #7536

Merged
merged 1 commit into from
+10 −10

Labels

None yet

Milestone

No milestone

Assignee

No one assigned

5 participants

@erictleung @camperbot @ltegman @raisedadead @BerkeleyTrue
@erictleung
erictleung commented

Tested locally. Passed npm run test-challenges. References #7085.

  • Change inventory function name to updateInventory in seeded code, solution, and tests
  • Update instructions to be more clear
@raisedadead raisedadead added the QA label
@ltegman ltegman and 1 other commented on an outdated diff
View full outdated diff
...-end-development-certification/advanced-bonfires.json
@@ -168,11 +168,11 @@
"id": "a56138aff60341a09ed6c480",
"title": "Inventory Update",
"description": [
- "Compare and update inventory stored in a 2d array against a second 2d array of a fresh delivery. Update current inventory item quantity, and if an item cannot be found, add the new item and quantity into the inventory array in alphabetical order.",
+ "Compare and update the inventory stored in a 2D array against a second 2D array of a fresh delivery. Update the current existing inventory item quantities (in <code>arr1</code>). If an item cannot be found, add the new item and quantity into the inventory array. The returned inventory array should in alphabetical order by item.",
@ltegman
Free Code Camp member
ltegman added a note

The sentence at the end should be 'The returned inventory array should be in alphabetical order by item.'

@erictleung
erictleung added a note

Ah, thanks for catching that! Just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@erictleung erictleung Make Inventory Update function name unique … 
- Change `inventory` function name to `updateInventory` in seeded code,
  solution, and tests
- Update instructions to be more clear
5d4138a
@camperbot
camperbot commented

@erictleung updated the pull request.

@ltegman
Free Code Camp member
ltegman commented

Thanks for updating this so quickly! :+1:

@ltegman ltegman merged commit 88c917c into FreeCodeCamp:staging
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@BerkeleyTrue BerkeleyTrue removed the QA label
@erictleung erictleung deleted the erictleung:fix/unique-function-name-for-inventory-update branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.