changed expire time for currentChallengeId cookie to 'never' #7568
+2
−1
4 participants
Kalcode
commented
Kalcode
changed the title from changed expire time for currentChallengeId cookie to changed expire time for currentChallengeId cookie to 'never'
1 check passed
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
server/boot/challenge.js
| @@ -515,7 +515,8 @@ module.exports = function(app) { | ||
| } | ||
| var view = challengeView[data.challengeType]; | ||
| if (data.id) { | ||
| - res.cookie('currentChallengeId', data.id); |
|
Line is still there, it was just changed with an additional parameter. Not sure what you are asking, "??" is a very unhelpful and ambiguous comment, if you could expand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Changed the currentChallengeId cookie expire time to 'never'. Currently set to session which doesnt not allow redirect.
Have not tested on locally. Chrome and Firefox debugs indicate cookie is set to 'session' as does express documentation if its not set. Modifying cookies allows me to sign in to website as intended.
This should at least fix the cases where redirect works fine with cookies.
-This is a re-submit of an earlier PR, i couldn't seem to squash my commits, i think cause i did the edits via github first and then tried to clone and squash.