Skip to content

/FreeCodeCamp

changed http to https in HTML5 & CSS3 #7613

Merged
merged 1 commit into from
+43 −43

Labels

QA

Milestone

No milestone

Assignee

No one assigned

5 participants

@AkiraLaine @camperbot @raisedadead @bugron @abhisekp
@AkiraLaine
Free Code Camp member
AkiraLaine commented

As described in title.

closes #7584
closes #7616

@camperbot
camperbot commented

@AkiraLaine updated the pull request.

@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
@@ -1291,11 +1291,11 @@
"<p class=\"red-text\">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p>"
],
"tests": [
- "assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").length > 0, 'message: You need an <code>a</code> element that links to \"http://www.freecatphotoapp.com\".');",
+ "assert($(\"a[href=\\\"https://www.freecatphotoapp.com\\\"]\").length > 0, 'message: You need an <code>a</code> element that links to \"https://www.freecatphotoapp.com\".');",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
"assert($(\"a\").text().match(/cat\\sphotos/gi), 'message: Your <code>a</code> element should have the anchor text of \"cat photos\"');",
"assert($(\"p\") && $(\"p\").length > 2, 'message: Create a new <code>p</code> element around your <code>a</code> element.');",
- "assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").parent().is(\"p\"), 'message: Your <code>a</code> element should be nested within your new <code>p</code> element.');",
- "assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").parent().text().match(/^\\s*View\\smore\\s/gi), 'message: Your <code>p</code> element should have the text \"View more \" (with a space after it).');",
+ "assert($(\"a[href=\\\"https://www.freecatphotoapp.com\\\"]\").parent().is(\"p\"), 'message: Your <code>a</code> element should be nested within your new <code>p</code> element.');",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
"assert($(\"a\").text().match(/cat\\sphotos/gi), 'message: Your <code>a</code> element should have the anchor text of \"cat photos\"');",
"assert($(\"p\") && $(\"p\").length > 2, 'message: Create a new <code>p</code> element around your <code>a</code> element.');",
- "assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").parent().is(\"p\"), 'message: Your <code>a</code> element should be nested within your new <code>p</code> element.');",
- "assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").parent().text().match(/^\\s*View\\smore\\s/gi), 'message: Your <code>p</code> element should have the text \"View more \" (with a space after it).');",
+ "assert($(\"a[href=\\\"https://www.freecatphotoapp.com\\\"]\").parent().is(\"p\"), 'message: Your <code>a</code> element should be nested within your new <code>p</code> element.');",
+ "assert($(\"a[href=\\\"https://www.freecatphotoapp.com\\\"]\").parent().text().match(/^\\s*View\\smore\\s/gi), 'message: Your <code>p</code> element should have the text \"View more \" (with a space after it).');",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
@@ -1283,7 +1283,7 @@
"",
"<h2 class=\"red-text\">CatPhotoApp</h2>",
"",
- "<a href=\"http://www.freecatphotoapp.com\">cat photos</a>",
+ "<a href=\"https://www.freecatphotoapp.com\">cat photos</a>",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
@@ -1363,7 +1363,7 @@
"",
"<h2 class=\"red-text\">CatPhotoApp</h2>",
"",
- "<p>Click here for <a href=\"http://www.freecatphotoapp.com\">cat photos</a>.</p>",
+ "<p>Click here for <a href=\"https://www.freecatphotoapp.com\">cat photos</a>.</p>",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead raisedadead commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
@@ -1212,7 +1212,7 @@
],
"tests": [
"assert((/cat photos/gi).test($(\"a\").text()), 'message: Your <code>a</code> element should have the <code>anchor text</code> of \"cat photos\".');",
- "assert(/http:\\/\\/freecatphotoapp\\.com/gi.test($(\"a\").attr(\"href\")), 'message: You need an <code>a</code> element that links to <code>http&#58;//freecatphotoapp.com</code>');",
+ "assert(/https:\\/\\/freecatphotoapp\\.com/gi.test($(\"a\").attr(\"href\")), 'message: You need an <code>a</code> element that links to <code>http&#58;//freecatphotoapp.com</code>');",
@raisedadead
Free Code Camp member
raisedadead added a note

To be reverted back to http ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead
Free Code Camp member
raisedadead commented

@AkiraLaine Seems you missed out on some of the reversals.
I'll take this up.

@raisedadead raisedadead added the blocked label
@camperbot
camperbot commented

@AkiraLaine updated the pull request.

@raisedadead
Free Code Camp member
raisedadead commented

This looks good by the diff and apparently should not break anything, but needs to be tested, while other wise good to go.

If anyone is available, please go ahead, else I'll be taking this up later today.

@bugron bugron commented on an outdated diff
View full outdated diff
...ront-end-development-certification/html5-and-css.json
@@ -1292,7 +1292,7 @@
],
"tests": [
"assert($(\"a[href=\\\"http://www.freecatphotoapp.com\\\"]\").length > 0, 'message: You need an <code>a</code> element that links to \"http://www.freecatphotoapp.com\".');",
- "assert($(\"a\").text().match(/cat\\sphotos/gi), 'message: Your <code>a</code> element should have the anchor text of \"cat photos\"');",
+ "assert($(\"a\").text().match(/cat\\sphotos/gi), 'mssage: Your <code>a</code> element should have the anchor text of \"cat photos\"');",
@bugron
bugron added a note

You've changed message to mssage which is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bugron bugron commented on the diff
View full changes
...ront-end-development-certification/html5-and-css.json
@@ -829,7 +829,7 @@
"description": [
"You can add images to your website by using the <code>img</code> element, and point to a specific image's URL using the <code>src</code> attribute.",
"An example of this would be:",
- "<code>&#60img src=\"http://www.your-image-source.com/your-image.jpg\"&#62</code>",
+ "<code>&#60img src=\"https://www.your-image-source.com/your-image.jpg\"&#62</code>",
@bugron
bugron added a note

On line 838 http://fonts.googleapis must be https://fonts.googleapis too.

@raisedadead
Free Code Camp member
raisedadead added a note

@bugron thanks for catching these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bugron
bugron commented

Also this PR closes 7616.

@AkiraLaine AkiraLaine changed http to https in HTML5 & CSS3 … 
reverted freecatphotoapp links to http

reverted all freecatphotoapp links to http

fixed more issues
668e47f
@alistermada alistermada referenced this pull request
Closed

FrontEnd tutorial must call https instead of http #7659

@camperbot
camperbot commented

@AkiraLaine updated the pull request.

@AkiraLaine
Free Code Camp member
AkiraLaine commented

Thanks @bugron for finding those. Updated description and PR :smile:

@abhisekp abhisekp commented on the diff
View full changes
...ront-end-development-certification/html5-and-css.json
@@ -686,7 +686,7 @@
"Agora, vamos importar e aplicar um estilo de fonte por meio do Google Fonts.",
"Primeiro, faça um <code>chamado</code> ao Google Fonts para poder utilizar a fonte chamada <code>Lobster</code> e carregá-la em seu HTML.",
"Para fazer isso, copie o código abaixo e insira-o na parte superior de seu editor de texto:",
- "<code>&#60;link href=\"http://fonts.googleapis.com/css?family=Lobster\" rel=\"stylesheet\" type=\"text/css\"&#62;</code>",
+ "<code>&#60;link href=\"https://fonts.googleapis.com/css?family=Lobster\" rel=\"stylesheet\" type=\"text/css\"&#62;</code>",
@abhisekp
Free Code Camp member
abhisekp added a note

Use protocol independent link //fonts.goo.... for all the links

@raisedadead
Free Code Camp member
raisedadead added a note

Nope that's going to confuse people. Its better this way. But having said that this could be done in actual code logic for FCC but not in challenges.

Can be shocker to beginners.

@abhisekp
Free Code Camp member
abhisekp added a note

"shocker" :scream_cat: :scream: :scream_cat:
Haha :smile:
Right :+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@raisedadead
Free Code Camp member
raisedadead commented

:+1: Thanks @AkiraLaine @bugron

@raisedadead raisedadead merged commit 842b026 into FreeCodeCamp:staging
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@raisedadead raisedadead referenced this pull request
Closed

Font Typo in CatPhotoApp #7683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.