Skip to content

/amplify

A better share link for twitter #12

Merged
merged 3 commits into from
+3 −2

Labels

None yet

Milestone

No milestone

Assignee

No one assigned

3 participants

@jk-gan @ageitgey @lavraalex
@jk-gan
jk-gan commented

(*) modified the url for sharing to twitter

@lavraalex
lavraalex commented on _layouts/post.html in c480429

Deleted

lavraalex replied

Delete all

lavraalex replied

Destroy

@ageitgey ageitgey commented on an outdated diff
View full outdated diff
_layouts/post.html
@@ -13,7 +13,7 @@ <h1 class="post-title">{{ page.title }}</h1>
</section>
<footer class="post-footer">
<section class="share">
- <a class="icon" href="http://twitter.com/share?text={{page.title | cgi_escape}}&amp;url={{site.url}}{{page.id}}" target="_blank">
+ <a class="icon" href="https://twitter.com/intent/tweet?url={{ site.url }}{{ page.id }}&text={{ page.title }}&via={{ site.twitter_username }}" target="_blank">
@ageitgey
Owner
ageitgey added a note

Can you add the | cgi_escape filter to page.title here to make sure page title doesn't contain any invalid characters when the url is generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ageitgey
Owner
ageitgey commented

Thanks!

@ageitgey ageitgey merged commit 176a7a6 into ageitgey:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.