Skip to content

/react

New issue

jquery-bootstrap example uses `handleHidden` which does not exist #5959

Closed
jimfb opened this Issue · 2 comments

Labels

good first bug

Milestone

No milestone

Assignee

No one assigned

3 participants

@jimfb @MarkMurphy @TheBlasfem
@jimfb
jimfb commented

Introduced in: 7f8b288

@jimfb jimfb added the good first bug label
@jimfb jimfb referenced this issue
@zpao zpao [examples] Use refs instead of findDOMNode 3c0f46e
@TheBlasfem TheBlasfem referenced this issue
Closed

Added handleHidden method to BootstrapModal in examples #5960

@MarkMurphy MarkMurphy added a commit to MarkMurphy/react that referenced this issue
@MarkMurphy MarkMurphy Fixes #5959 - jquery-bootstrap example uses which does not exist 3d1e79e
@MarkMurphy MarkMurphy referenced this issue
Merged

Fixes #5959 - jquery-bootstrap example uses handleHidden which does not exist #5961

@MarkMurphy
MarkMurphy commented

@TheBlasfem you beat me to it haha! I noticed though that your fix doesn't address the fact that no event listener was added for the 'hidden' event to begin with. Also, the event name is actually hidden.bs.modal. I've made those changes in mine in addition to responding to the same onHidden prop you also implemented.

@TheBlasfem
TheBlasfem commented

nice catch @MarkMurphy, thanks for notice me, we can continue with your solution

@MarkMurphy MarkMurphy added a commit to MarkMurphy/react that referenced this issue
@MarkMurphy MarkMurphy Fixes #5959 - jquery-bootstrap example uses which does not exist 
1. Add a handleHidden method to the BootstrapModal component.
2. Add an event listener for 'hidden.bs.modal' on the modal root
3. Add a new onHidden prop to the BootstrapModal component.
4. Add a new 'handleModalDidClose' method to the Example component to be used as the onHidden prop of it's modal component.
 0bd65aa
@jimfb jimfb closed this in #5961
@milesj milesj added a commit to milesj/react that referenced this issue
@MarkMurphy MarkMurphy Fixes #5959 - jquery-bootstrap example uses which does not exist 
1. Add a handleHidden method to the BootstrapModal component.
2. Add an event listener for 'hidden.bs.modal' on the modal root
3. Add a new onHidden prop to the BootstrapModal component.
4. Add a new 'handleModalDidClose' method to the Example component to be used as the onHidden prop of it's modal component.
 cad6041
@alunyov alunyov added a commit to alunyov/react that referenced this issue
@MarkMurphy MarkMurphy Fixes #5959 - jquery-bootstrap example uses which does not exist 
1. Add a handleHidden method to the BootstrapModal component.
2. Add an event listener for 'hidden.bs.modal' on the modal root
3. Add a new onHidden prop to the BootstrapModal component.
4. Add a new 'handleModalDidClose' method to the Example component to be used as the onHidden prop of it's modal component.
 e77a5b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.