Skip to content

/react

getEventCharCode unit tests #6307

Merged
merged 1 commit into from
+89 −0

Labels

CLA Signed GH Review: review-needed

Milestone

No milestone

Assignee

No one assigned

3 participants

@cbrwizard @facebook-github-bot @jimfb
@cbrwizard
cbrwizard commented

Adds unit tests to getEventCharCode.

getEventCharCode lacks test coverage, so here is a fix.

Before

2016-03-21 11 17 06
2016-03-21 12 16 23

After

2016-03-21 12 12 03
2016-03-21 12 14 41

Small but steady! If there are any issues with the code - feel free to point me to mistakes, I will be glad to fix them [:

@cbrwizard cbrwizard getEventCharCode unit tests … 
Adds unit tests to getEventCharCode.
7bdf4db
@facebook-github-bot
facebook-github-bot commented

@cbrwizard updated the pull request.

@jimfb
jimfb commented

Thanks @cbrwizard!

@jimfb jimfb merged commit c528732 into facebook:master
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.