Skip to content

Added instructions for RecyclerAdapter cleanup & corrected method names #88

Merged
merged 1 commit into from

2 participants

@roughike

Somebody that wants to jump right in and use the RecyclerAdapter, might just skip through the ListAdapter example and forget to call cleanup() on it.

Also, the method name seemed to be incorrect in the instructions but right in the code: instead of release() the correct method is cleanup() just like above.

@roughike roughike Added instructions for RecyclerAdapter cleanup & corrected method names
Somebody that wants to jump right in and use the `RecyclerAdapter`, might just skip through the `ListAdapter` example and forget to call `cleanup()` on it.

Also, the method name seemed to be incorrect in the instructions but right in the code: instead of `release()` the correct method is `cleanup()` just like above.
e19bafa
@puf puf merged commit de3c357 into firebase:master
@puf
puf commented

Thanks for the PR and good catches. I'm not sure how that release() snuck in there, because the method has always been called cleanup(). Well.... fixed now. Thanks again!

@roughike

@puf
No probs, man! Thank you for the awesome product!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.