Update nationalPrefixOptionalWhenFormatting documentation.

googlei18n · a342989093fbd56c75b3cba655b3107d4d9a823a · keghani committed Feb 29, 2016 · Feb 29, 2016 · a342989
1 parent 90fb886
commit a342989093fbd56c75b3cba655b3107d4d9a823a
Unified Split

Showing with 9 additions and 6 deletions.

+4 −0 java/release_notes.txt

+1 −1 resources/phonemetadata.proto

+4 −5 tools/java/common/src/com/google/i18n/phonenumbers/BuildMetadataFromXml.java
@@ -1,3 +1,7 @@
+Pending changes:
+Code changes:
+ - Update nationalPrefixOptionalWhenFormatting documentation.
+
 Feb 25, 2016: libphonenumber-7.2.6
 Metadata changes:
  - Updated phone metadata for region code(s): DJ, MA, NA, US
@@ -82,7 +82,7 @@ message NumberFormat {
   // commonly seen this number written by people without the leading 0, for
   // example as (20) XXXX XXXX, this field would be set to true. This will be
   // inherited from the value set for the territory in the XML file, unless a
-  // national_prefix_formatting_rule is defined specifically for this
+  // national_prefix_optional_when_formatting is defined specifically for this
   // NumberFormat.
   optional bool national_prefix_optional_when_formatting = 6;
 
@@ -294,10 +294,10 @@ static void loadNationalFormat(PhoneMetadata metadata, Element numberFormatEleme
   }
 
   /**
-   *  Extracts the available formats from the provided DOM element. If it does not contain any
-   *  nationalPrefixFormattingRule, the one passed-in is retained. The nationalPrefix,
-   *  nationalPrefixFormattingRule and nationalPrefixOptionalWhenFormatting values are provided from
-   *  the parent (territory) element.
+   * Extracts the available formats from the provided DOM element. If it does not contain any
+   * nationalPrefixFormattingRule, the one passed-in is retained; similarly for
+   * nationalPrefixOptionalWhenFormatting. The nationalPrefix, nationalPrefixFormattingRule and
+   * nationalPrefixOptionalWhenFormatting values are provided from the parent (territory) element.
    */
   // @VisibleForTesting
   static void loadAvailableFormats(PhoneMetadata metadata,
@@ -324,7 +324,6 @@ static void loadAvailableFormats(PhoneMetadata metadata,
         } else {
           format.nationalPrefixFormattingRule = nationalPrefixFormattingRule;
         }
-
         if (numberFormatElement.hasAttribute(NATIONAL_PREFIX_OPTIONAL_WHEN_FORMATTING)) {
           format.nationalPrefixOptionalWhenFormatting =
               Boolean.valueOf(numberFormatElement.getAttribute(