John Britton

johndbritton

What do you think about adding a hidden input with repository_id as value and we can use the value if it's present? Yeah, I like this idea. By de…

Yeah, I see that we need the access token from the user, but why does this client belong on the user? Couldn't you also do something in the control…

I don't love that we're adding another method to the User here. Why is this the right place for this code?

And it also just feels cleaner to reference by repository_id

@OrthoDex If you make a pull request with your current code we can give you some feedback.

What do you think about modifying the form to submit repository_id when using autocompletion instead of sending name/owner? I know it's an unlikely…

I wasn't exactly sure how to get hold of them from the app. @ConnorCartwright You should have your own OAuth application for development and stor…

This is a fix to #442. @dinever Just an FYI, if you use the term Fixes #442, Closes #442 or similar in your pull request, the issue will automati…

Fixed in #506

@cyhsutw looks great. Would it be possible to add autocomplete for the org / user login component as well?

This looks good to me. Thanks for the contribution @dinever. @tarebyte If you verified this, I say go for it. Maybe file another issue about the Tu…

A third solution would be to change our routes to be id based.

I wonder if we should fix this by truncating the name of the organization into 60 characters when it's too long. That's one possible solution, al…

@willprice Thanks for the additional information, it looks like this error is being caused because the name of your organization is too long for Cl…

his student user is only used in the context user without admin privilege on the organization now. So I think student should be enough. Sorry, pa…

/autocomplete/repositories?q=keyword I think a new namespace is cleaner. What do you say @tarebyte?

the student here is the admin of the organization in the VCR record of the test case. Maybe we should change the name from :student to :teaching_…

@dinever Thanks for your contribution. I just left one comment about an expect that you don't need, but aside from that this looks good to me. @tar…

@dinever You should remove this line.

@willprice Can you give us a bit more context: What page is this on? What are you trying to do?

since the factory creates an org with a user, I believe this needs a call to organization.save!

this expect is not necessary

This expect is not necessary

Is there a better name for this method? Suggestions @tarebyte?

I think this is easier to understand: def auto_scan_organizations_access @users_github_organizations.each do |organization| organization = organiz…

with this request though we're only getting the first 100 organization for a user @tarebyte I believe we're using Octokit's auto-pagination featu…

I want to give students (who have an existing assignment repository) new code to that repository I think this is a common enough workflow that we…