Skip to content

bower.json - The files listed under the main key are wrong #2740

Closed
mpetkov opened this Issue · 4 comments

5 participants

@mpetkov

I tried installing the component using the Main Bower gulp plugin in my project. This plugin is supposed to copy only the files listed in the main key that are the only files needed to run the module. Well right now the listed files are the ones in src however it should have a list of the dist files.

@DatTran

Also bower pulls in the SASS file instead of the css.

"main": [
    "src/js/video.js",
    "src/css/video-js.scss"
  ],

Should be:

"main": [
    "dist/video-js.js",
    "dist/video-js.css"
  ],
@mmcc
Video.js member

@DatTran want to submit a PR to fix it?

@DatTran DatTran added a commit to DatTran/video.js that referenced this issue
@DatTran DatTran Bower Path Fixes #2740 d87a868
@misteroneill
Video.js member

This one is also related to #2611

@gkatsev
Video.js member

The PR for this: #2775

@gkatsev gkatsev added the confirmed label
@gkatsev gkatsev closed this in 7dff83b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.