Skip to content

/video.js

Add ISSUE_TEMPLATE for github. #3117

Closed
wants to merge 5 commits into from
+48 −0

Labels

confirmed patch

Milestone

No milestone

Assignee

No one assigned

3 participants

@gkatsev @dmlap @heff
@gkatsev
Video.js member
gkatsev commented

See https://github.com/blog/2111-issue-and-pull-request-templates

@dmlap
Video.js member
dmlap commented

Cool! Notes:

  • link to jsbin.com/axedog for the reduced test cases?
  • The STR numbering doesn't render correctly in github markdown right now
@gkatsev
Video.js member
gkatsev commented

Yeah, the number doesn't render correctly without content. When new issues are included, they're in "write" mode and not "preview" mode, so, it should be OK.

@dmlap
Video.js member
dmlap commented

The PR template is awesome for new features. I wouldn't want to set the bar that high for simple bug fixes, though. Any way to split the difference?

@gkatsev
Video.js member
gkatsev commented

Not sure. A lot of that applies should apply to "simple bug fixes" as well. Maybe we just need better/simpler wording.

@heff
Video.js member
heff commented

Nice! Love this feature. lgtm

@gkatsev
Video.js member
gkatsev commented

@dmlap I updated the wording in the PR Template. Please take another look.

@dmlap
Video.js member
dmlap commented

:+1:

@gkatsev gkatsev added confirmed and removed needs: LGTM labels
@gkatsev gkatsev added a commit that closed this pull request
@gkatsev gkatsev @gkatsev added issue and PR templates for github. closes #3117 050f23d
@gkatsev gkatsev closed this in 050f23d
@gkatsev gkatsev deleted the gkatsev:issue-templates branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.