Skip to content

XHR and updatedisplay fixes for IE8 #3189

Closed
wants to merge 8 commits into from

2 participants

@gkatsev
Video.js member

No description provided.

gkatsev added some commits
@gkatsev gkatsev XHR and updatedisplay fixes for IE8
843c91d
@gkatsev gkatsev use proxyquire instead of xhr.onCreate
f2472fb
@gkatsev gkatsev reload TextTrack without stubs
77de5e1
@gkatsev gkatsev add proxyquireify to karma browserify config
9f22f5b
@gkatsev gkatsev point at the correct file
5ff2c71
@gkatsev gkatsev remove unncessary change 0b6ed05
@gkatsev gkatsev clear out the onload and onerror of the script on dispose
dc81e48
@dmlap dmlap commented on the diff
src/js/tech/tech.js
@@ -333,6 +333,10 @@ class Tech extends Component {
script.onerror = () => {
this.trigger('vttjserror');
};
+ this.on('dispose', () => {
@dmlap
Video.js member
dmlap added a note

Dope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@dmlap
Video.js member

Could use a little more exposition around the use of proxyrequire but otherwise LGTM

@gkatsev gkatsev Add a comment and rename xhr to xhrHandler
4e532d0
@dmlap
Video.js member

LGTM

@gkatsev gkatsev closed this in dbdc411
@gkatsev gkatsev deleted the fix-ie8-tests branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.